Remove MyReal and MPI_Double incl. defs.hpp #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffi7574
reviewed
Jul 14, 2019
steffi7574
left a comment
steffi7574
left a comment
There was a problem hiding this comment.
I understand the desire to remove the MyReal define, but it actually comes in handy if you want to change from double to single precision, which might be desirable in some cases.
Owner
Author
|
Please provide an example, where it is useful.
|
|
In cases where storing double precision is not possible due to memory limitations. We faced that problem already when optimizing on MNIST using a very big batch within the XBraid vectors. We were switching to mini-batch optimization and single precision then to reduce memory. |
Owner
Author
|
😨 ... do you have this test? Can you add it to the repo? |
Owner
Author
|
Please put a recipe for this in here. |
Owner
Author
|
Makefile for two different versions. See holy single vs. double precision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.